Generic IO #1746
Merged
Generic IO #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
reviewed
Jul 24, 2023
tzemanovic
reviewed
Jul 24, 2023
tzemanovic
previously approved these changes
Jul 24, 2023
tzemanovic
previously approved these changes
Jul 25, 2023
mateuszjasiuk
previously approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Sorry for late review!
So I was able to implement the trait in browser.
In general all of this works great, the two things to comes to my mind though:
- Sometimes it is a bit annoying to pass generic IO as last type
namada::ledger::tx::build_transfer::<_, _, _, IO>, as first three types can be inferred - it would be nice to make prompt and read async. The reason is that when we use those functions in the extension background(service worker) we do not have access to prompt(or any other DOM related features). So to make it work we would have to do something like this: stackblitz. On the other hand though, at the moment we are not using prompts at all, so this might not be such a big issue.
|
So I can change the order of the generic arguments, but it's a choice of |
batconjurer
dismissed stale reviews from mateuszjasiuk and tzemanovic
via
cfb57ab
|
However, I made the |
Ah my bad, I thought they can be skipped the same as in TS 😅 |
mateuszjasiuk
previously approved these changes
Jul 26, 2023
tzemanovic
reviewed
Jul 27, 2023
tzemanovic
reviewed
Jul 27, 2023
tzemanovic
previously approved these changes
Jul 27, 2023
mateuszjasiuk
previously approved these changes
Jul 28, 2023
sug0
requested changes
Aug 14, 2023
batconjurer
dismissed stale reviews from mateuszjasiuk and tzemanovic
via
c855632
sug0
previously approved these changes
Aug 16, 2023
tzemanovic
previously approved these changes
Aug 16, 2023
Closed
batconjurer
added a commit
that referenced
this pull request
Sep 18, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
* origin/bat/generic-io: [chore]: Merge in 0.21.1 [fix]: Removed unused file [feat]: Changed default io read methods to use tokio's async io tools [feat]: Changed default io read methods to use tokio's async io tools [feat]: Made io reading methods async changelog: add #1746 [chore]: Added IO macros to wallet cli. Renamed to [fix]: Fixed intra-doc link typo [feat]: Made sdk and client io generic
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code replaces IO in sdk and client code with a trait that allows custom IO handling.